Repository navigation
Add a shared NuGet icon for the MarkupString packages - #64
Merged
Merged
Conversation
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 33 minutes for your next included review. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embed a shared transparent 128×128 NuGet icon in MarkupString, Ansi, Html, Mxp, and Pueblo. The icon uses turquoise angle brackets around three colored text strokes; the existing documentation logo is preserved.
Shared targets select the five published PackageIds and include the icon at the package root. The larger source artwork is retained alongside the package icon.
Validation: packed all five packages from current main (v2.18.1), inspected their nuspec icon entries, and verified that each archive contains the exact expected 128×128 PNG.
git diff --checkpasses. No runtime code changed.